Skip to content

[PR #10907/b25eca01 backport][3.12] Fix flakey test_uvloop_secure_https_proxy test #10909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 20, 2025

This is a backport of PR #10907 as merged into master (b25eca0).

This is another attempt to fix this flakey test. Sadly it only fails in the CI, and only sometimes

@bdraco bdraco enabled auto-merge (squash) May 20, 2025 20:37
Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10909 will not alter performance

Comparing patchback/backports/3.12/b25eca0144e618a91b78c3b0f348503db2510657/pr-10907 (e1ab394) with 3.12 (64fc600)

Summary

✅ 60 untouched benchmarks

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (64fc600) to head (e1ab394).
Report is 2 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10909   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         130      130           
  Lines       39282    39283    +1     
  Branches     2223     2223           
=======================================
+ Hits        38561    38562    +1     
  Misses        551      551           
  Partials      170      170           
Flag Coverage Δ
CI-GHA 98.05% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.78% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.25% <0.00%> (+<0.01%) ⬆️
OS-macOS 96.95% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.38% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 97.48% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.93% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 97.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.26% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 83.42% <0.00%> (-3.88%) ⬇️
VM-macos 96.95% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.78% <100.00%> (+<0.01%) ⬆️
VM-windows 95.25% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 9a2835a into 3.12 May 20, 2025
36 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/b25eca0144e618a91b78c3b0f348503db2510657/pr-10907 branch May 20, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant