-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove mocked coro #10910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mocked coro #10910
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10910 +/- ##
==========================================
- Coverage 98.75% 98.75% -0.01%
==========================================
Files 129 129
Lines 38938 39072 +134
Branches 2164 2164
==========================================
+ Hits 38454 38586 +132
- Misses 336 337 +1
- Partials 148 149 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10910 will degrade performances by 8.64%Comparing Summary
Benchmarks breakdown
|
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 36a2567 on top of patchback/backports/3.11/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910 Backporting merged PR #10910 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 36a2567 on top of patchback/backports/3.12/36a2567d96903007a2b6ff6c10af9392767bfe0f/pr-10910 Backporting merged PR #10910 into master
🤖 @patchback |
(cherry picked from commit 36a2567)
trace = mock.Mock() | ||
trace.send_response_chunk_received = make_mocked_coro() | ||
trace.send_response_chunk_received = mock.AsyncMock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally most of these should be replaced with create_autospec(), if anyone is willing to do a bit more on these and help make the code more robust.
What do these changes do?
Removed a function that was redundant to AsyncMock functionality.
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
No.
Related issue number
Fixes #9212
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.