Skip to content

Remove manual release call in middleware #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Remove manual release call in middleware #10952

merged 2 commits into from
May 22, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 22, 2025

This should no longer be needed now that we have resolved the root cause.

closes #10901

This should no longer be needed now that we have resolved the root cause.

closes #10901
@bdraco bdraco added this to the 3.12 milestone May 22, 2025
@bdraco bdraco requested a review from asvetlov as a code owner May 22, 2025 21:54
@bdraco bdraco requested a review from webknjaz as a code owner May 22, 2025 21:55
@bdraco bdraco added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label May 22, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 22, 2025
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Performance Report

Merging #10952 will not alter performance

Comparing release_remove (6afa679) with master (06e3b36)

Summary

✅ 59 untouched benchmarks

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (06e3b36) to head (6afa679).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10952      +/-   ##
==========================================
- Coverage   98.77%   98.77%   -0.01%     
==========================================
  Files         129      129              
  Lines       39539    39536       -3     
  Branches     2186     2185       -1     
==========================================
- Hits        39054    39051       -3     
  Misses        337      337              
  Partials      148      148              
Flag Coverage Δ
CI-GHA 98.65% <ø> (-0.01%) ⬇️
OS-Linux 98.36% <ø> (-0.01%) ⬇️
OS-Windows 96.53% <ø> (-0.01%) ⬇️
OS-macOS 97.51% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.40% <ø> (-0.01%) ⬇️
Py-3.10.17 97.94% <ø> (-0.01%) ⬇️
Py-3.11.12 98.02% <ø> (-0.01%) ⬇️
Py-3.11.9 97.48% <ø> (+<0.01%) ⬆️
Py-3.12.10 98.42% <ø> (-0.01%) ⬇️
Py-3.13.3 98.41% <ø> (-0.01%) ⬇️
Py-3.9.13 97.28% <ø> (+<0.01%) ⬆️
Py-3.9.22 97.80% <ø> (-0.01%) ⬇️
Py-pypy7.3.16 93.57% <ø> (+8.59%) ⬆️
VM-macos 97.51% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.36% <ø> (-0.01%) ⬇️
VM-windows 96.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 45b74cf into master May 22, 2025
60 of 71 checks passed
@bdraco bdraco deleted the release_remove branch May 22, 2025 22:20
Copy link
Contributor

patchback bot commented May 22, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/45b74cfccbbe44036c4a2ca45154d3dcbfc11af6/pr-10952

Backported as #10953

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 22, 2025
bdraco added a commit that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why .release() is needed in middleware for reliable connection release
1 participant