Skip to content

Remove manual release call in middleware #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Remove manual release call in middleware #10952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505f462
Remove manual release call in middleware
bdraco May 22, 2025
6afa679
changelog
bdraco May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/10952.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
9732.feature.rst
2 changes: 0 additions & 2 deletions aiohttp/client_middleware_digest_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,6 @@ async def __call__(
# Check if we need to authenticate
if not self._authenticate(response):
break
elif retry_count < 1:
response.release() # Release the response to enable connection reuse on retry

# At this point, response is guaranteed to be defined
assert response is not None
Expand Down
1 change: 0 additions & 1 deletion tests/test_client_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,6 @@ async def __call__(
response = await handler(request)
if retry_count == 0:
retry_count += 1
response.release() # Release the response to enable connection reuse
continue
return response

Expand Down
Loading