feat: add validated variants to ABI decoding methods #928
+388
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-ps-2003
requested review from
DaniPopes,
mattsse and
yash-atreya
as code owners
DaniPopes
requested changes
Apr 16, 2025
DaniPopes
changed the title
abi_validation methods for ABI decoding across various types
DaniPopes
changed the title
abi_validation methods for ABI decoding across various types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The fundamental motivation behind these changes is to re-introduce ABI decoding validation that was effectively removed by default in PR #863
This PR removed the validate: bool argument from decoding functions (abi_decode*). The reason was that the existing validation logic was sometimes too strict and incorrectly rejected valid ABI-encoded data found in real-world scenarios. Removing the flag made the default decoding behavior non-validating (or less strict).
However, performing strict ABI validation is still a desirable feature for users who want to ensure data adheres precisely to the expected format, potentially catching encoding errors or unexpected data structures early.
Fixes #927
Solution
So, instead of re-introducing the boolean flag (which complicates the function signatures), the chosen approach was to add separate, parallel methods specifically for validated decoding. These new methods have _validate appended to their names.
PR Checklist