Leverage Iceberg-Rust for all the transforms #1833
Draft
+79
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Mar 27, 2025
| (TimestampType(), datetime.datetime(19, 5, 1, 22, 1, 1)), | ||
| (TimestamptzType(), datetime.datetime(19, 5, 1, 22, 1, 1, tzinfo=datetime.timezone.utc)), | ||
| (TimestampType(), datetime.datetime(2022, 5, 1, 22, 1, 1)), | ||
| (TimestamptzType(), datetime.datetime(2022, 5, 1, 22, 1, 1, tzinfo=datetime.timezone.utc)), |
There was a problem hiding this comment.
do you want to merge #1592 into this PR?
| @@ -186,8 +186,8 @@ def test_partition_type(table_schema_simple: Schema) -> None: | |||
| (DecimalType(5, 9), Decimal(19.25)), | |||
| (DateType(), datetime.date(1925, 5, 22)), | |||
| (TimeType(), datetime.time(19, 25, 00)), | |||
| (TimestampType(), datetime.datetime(19, 5, 1, 22, 1, 1)), | |||
| (TimestamptzType(), datetime.datetime(19, 5, 1, 22, 1, 1, tzinfo=datetime.timezone.utc)), | |||
| (TimestampType(), datetime.datetime(2022, 5, 1, 22, 1, 1)), | |||
There was a problem hiding this comment.
First, I thought it was some kind of clock correction somewhere in time that was accounted by one, and not the other. Digging into it deeper, it looks like there is an issue with negative numbers in general:
> assert t.transform(source_type)(value) == t.pyarrow_transform(source_type)(pa.array([value])).to_pylist()[0]
E assert -2 == -1
E + where -2 = <function HourTransform.transform.<locals>.<lambda> at 0x143fa6e60>(datetime.datetime(1969, 12, 31, 22, 1, 1))
E + where <function HourTransform.transform.<locals>.<lambda> at 0x143fa6e60> = <bound method HourTransform.transform of HourTransform()>(TimestampType())
E + where <bound method HourTransform.transform of HourTransform()> = HourTransform().transform
There was a problem hiding this comment.
Got a fix here: apache/iceberg-rust#1146
| try: | ||
| import pyarrow as pa | ||
| except ModuleNotFoundError as e: | ||
| raise ModuleNotFoundError("For bucket/truncate transforms, PyArrow needs to be installed") from e |
There was a problem hiding this comment.
nit: change this error message since we use this for all pyarrow transforms
Fokko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Testing out to use Iceberg Rust for all of the transforms. I think we have some rounding error in apache/iceberg-rust#1128
Are these changes tested?
Are there any user-facing changes?