Skip to content

Fix specular cutoff on lights with radius overlapping with mesh #19157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

Fix specular cutoff on lights with radius overlapping with mesh #19157

merged 2 commits into from
May 12, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented May 10, 2025

Objective

Solution

  • Clamp a dot product to be positive to avoid choosing a centerToRay which is not on the ray but behind it.

Testing

Main:
{DA2A2B99-27C7-4A76-83B6-CCB70FB57CAD}

This PR:
{2C4BC3E7-C6A6-4736-A916-0366FBB618DA}

Eevee reference:
329697008-ff28a5f3-27f3-4e98-9cee-d836a6c76aee

@atlv24 atlv24 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered labels May 10, 2025
@superdump superdump added this pull request to the merge queue May 12, 2025
Merged via the queue into bevyengine:main with commit 673e70c May 12, 2025
32 checks passed
@superdump superdump added this to the 0.16.1 milestone May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@mate-h mate-h mate-h approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.

Lights with radius overlapping with mesh result in sharp specular cutoff
3 participants
@atlv24 @superdump @mate-h