Skip to content

fix(render): transitive shader imports now work consistently on web #19266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented May 17, 2025

Objective

Solution

  • Don't return Ok, return the appropriate error code which will retry the load later when the dependencies load

Testing

  • bevy run --example=3d_scene web --open

Note: this is was theoretically a problem before the hot reloading PR, but probably extremely unlikely to occur.

@atlv24 atlv24 added this to the 0.16.1 milestone May 17, 2025
@atlv24 atlv24 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels May 17, 2025
@atlv24 atlv24 added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label May 17, 2025
@superdump superdump added this pull request to the merge queue May 17, 2025
Merged via the queue into bevyengine:main with commit eed1dc4 May 17, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

'bevy_render::maths' import path not found on web
3 participants