Add missing doc comments to system_information_diagnostics_plugin #19267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherphil
added
C-Docs
janhohenheim
added
S-Needs-Review
janhohenheim
approved these changes
May 18, 2025
| pub kernel: String, | ||
| /// CPU brand, for example 'Apple M1 Max'. |
There was a problem hiding this comment.
I assume that's a real-world example? i.e. this string looks exactly like that on a real M1 Max?
There was a problem hiding this comment.
Yes. I wasn't sure what this was so ran it on my laptop and copied the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
More trivial doc comments towards being able to deny missing docs across the board.