Skip to content

refactor(render): cleanup add_import_to_composer #19269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

refactor(render): cleanup add_import_to_composer #19269

merged 1 commit into from
May 18, 2025
+16 −19

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented May 17, 2025

Objective

  • Reduce nesting

Solution

  • Refactor

Testing

  • bevy run --example=3d_scene web --open

@atlv24 atlv24 added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels May 17, 2025
@atlv24 atlv24 added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label May 17, 2025
@atlv24 atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 17, 2025
@superdump superdump added this pull request to the merge queue May 18, 2025
Merged via the queue into bevyengine:main with commit 45ba5b9 May 18, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@eero-lehtinen eero-lehtinen eero-lehtinen approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atlv24 @superdump @eero-lehtinen @tychedelia