Implement closest_point for Segment[23]d. #20130
Conversation
IQuick143
added
C-Feature
| let closest = segment.closest_point(*point); | ||
| assert!( | ||
| point.distance_squared(closest) <= point.distance_squared(segment.point1()), | ||
| "Closest point must always at least as close as either vertex." |
There was a problem hiding this comment.
I think this sentence is missing a "be"
| @@ -2349,15 +2349,15 @@ mod tests { | |||
| let closest = segment.closest_point(*point); | |||
| assert!( | |||
| point.distance_squared(closest) <= point.distance_squared(segment.point1()), | |||
| "Closest point must always at least as close as either vertex." | |||
| "Closest point must always at be least as close as either vertex." | |||
There was a problem hiding this comment.
hum, it's "must always be at least" x) sorry for pestering :p
There was a problem hiding this comment.
Brain not working today, oops.
There was a problem hiding this comment.
Looks good! Pretty much exactly the same implementation as what I have in Peck.
This uses a more intuitive and simple approach in terms of the naming and comments, whereas I (and Parry, Box2D, etc.) explicitly describe the barycentric coordinates and Voronoi regions (see the version I linked on Discord). Both are fine for this line segment case, but for the more complicated simplices like triangles and tetrahedra, IMO you really need to use Voronoi regions to make sense of things.
I'm kind of biased towards using barycentric coordinates and Voronoi regions for all simplices to have them be more consistent and kind of build on each other, but I'm fine with this for now :)
|
Also I expect these to be moved under a trait like |
IQuick143
added
S-Ready-For-Final-Review
Objective
Solution
Testing