Skip to content

Text2d bounding box fix #20148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Text2d bounding box fix #20148

wants to merge 3 commits into from
+11 −14

Conversation

ickshonpe
Copy link
Contributor

Objective

calculate_bounds_text2d generates Aabbs with the wrong size and position for Text2d entities with TextBounds, which breaks culling.

Solution

Calculate the correct bounds.

Fixes #20145

Testing

cargo run --example testbed_2d

main

text2daabb

This PR

fixed-text2d-aabbs

@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Jul 15, 2025
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jul 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-20148

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

@alice-i-cecile
Copy link
Member

@ejrh can I get your review here? :)

@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward P-Regression Functionality that used to work but no longer does. Add a test for this! labels Jul 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-20148

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

ejrh
ejrh approved these changes Jul 15, 2025
View reviewed changes
Copy link

@ejrh ejrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejrh ejrh ejrh approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.

Text2d Aabb aren't in the right place and can get culled when they shouldn't
3 participants
@ickshonpe @alice-i-cecile @ejrh