Skip to content

fix: Error alert flash when loading file details directly #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix: Error alert flash when loading file details directly #4779

merged 1 commit into from
Apr 8, 2025

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Apr 3, 2025 •
edited
Loading

Closes #2372 #4752 #4760

Changes proposed in this pull request:

  • Fixes a flash error alert that happens when a file's detail url is loaded by checking to make sure the files cache is loaded first.
  • Updates to use lastModifiedBy and lastModifiedAt fields in the file details
  • Fixes link to file by adding liveDomain attribute to site API response

Notes

  • Edge cases may occur when sharing a file link and add additional files are added or removed from a directory which could impact the page items and order

security considerations

None

@apburnes apburnes requested a review from a team April 3, 2025 20:47
@cloud-gov-pages-operations
Copy link
Contributor

cloud-gov-pages-operations commented Apr 3, 2025 •
edited
Loading

🤖 This is an automated code coverage report

Total coverage (lines): 34.04%
Coverage diff: 0.09% 📈

KKAtila
KKAtila previously approved these changes Apr 3, 2025
View reviewed changes
@apburnes apburnes force-pushed the fix-file-view-details-alert-flash branch from bd01197 to 8f79e89 Compare April 3, 2025 21:00
@KKAtila KKAtila requested review from KKAtila and removed request for KKAtila April 7, 2025 13:28
@apburnes apburnes changed the title fix: Error alert falsh when loading file details directly fix: Error alert flash when loading file details directly Apr 7, 2025
@apburnes apburnes force-pushed the fix-file-view-details-alert-flash branch from 8f79e89 to ad41c65 Compare April 7, 2025 19:07
@apburnes apburnes requested a review from a team April 7, 2025 19:18
@apburnes apburnes force-pushed the fix-file-view-details-alert-flash branch from ad41c65 to 2ed8065 Compare April 7, 2025 20:58
@sknep sknep self-requested a review April 8, 2025 14:53
sknep
sknep approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@sknep sknep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! it looks great

@apburnes apburnes merged commit bc76e51 into main Apr 8, 2025
8 checks passed
@apburnes apburnes deleted the fix-file-view-details-alert-flash branch April 8, 2025 15:28
This was referenced Apr 8, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sknep sknep sknep approved these changes

@KKAtila KKAtila KKAtila left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apburnes @cloud-gov-pages-operations @sknep @KKAtila