Skip to content

Support image name without account ID #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025

Conversation

gpanders
Copy link
Member

@gpanders gpanders commented Jul 1, 2025

Fixes CC-5603

If a user uses an image in the Cloudflare managed registry they can specify the image name without including their full account ID. For example:

image = "registry.cloudflare.com/hello/world:1.0"

will now "just work", as Wrangler will automatically include their account ID in the appropriate location when creating the application. This matches the new behavior in the Dash, where we also omit the account ID in the image name.


@gpanders gpanders requested review from a team as code owners July 1, 2025 18:51
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: a65d3bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jul 1, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9813

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9813

miniflare

npm i https://pkg.pr.new/miniflare@9813

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9813

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9813

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9813

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9813

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9813

wrangler

npm i https://pkg.pr.new/wrangler@9813

commit: a65d3bc

@gpanders gpanders force-pushed the push-oxmlnmluomut branch 3 times, most recently from 83b2412 to 65a928b Compare July 2, 2025 14:17
@gpanders
Copy link
Member Author

gpanders commented Jul 3, 2025

Resolved conflicts and rebased on main

@gpanders gpanders mentioned this pull request Jul 3, 2025
6 tasks
gpanders added a commit to gpanders/cloudflare-docs that referenced this pull request Jul 3, 2025
Once cloudflare/workers-sdk#9813 is merged,
users will not need to add their account ID namespace to the image name.
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 3, 2025
@gpanders gpanders added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 3, 2025
@gpanders gpanders force-pushed the push-oxmlnmluomut branch from 19e464b to 70fd6c8 Compare July 3, 2025 15:12
@gpanders gpanders enabled auto-merge July 3, 2025 15:12
If a user uses an image in the Cloudflare managed registry they can
specify the image name without including their full account ID. For
example:

  image = "registry.cloudflare.com/hello/world:1.0"

will now "just work", as Wrangler will automatically include their
account ID in the appropriate location when creating the application.
This matches the new behavior in the Dash, where we also omit the
account ID in the image name.
@gpanders gpanders force-pushed the push-oxmlnmluomut branch from 70fd6c8 to 87aca00 Compare July 3, 2025 15:40
@gpanders gpanders force-pushed the push-oxmlnmluomut branch from a3cf5b6 to a65d3bc Compare July 3, 2025 17:02
@gpanders gpanders added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@gpanders gpanders added this pull request to the merge queue Jul 3, 2025
Merged via the queue into cloudflare:main with commit 45497ab Jul 3, 2025
55 of 62 checks passed
@gpanders gpanders deleted the push-oxmlnmluomut branch July 3, 2025 20:52
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 3, 2025
@workers-devprod workers-devprod mentioned this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants