Skip to content

Fix comment and test #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2012
Merged

Fix comment and test #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
081353d
Fix comment added in 281ad6d42ef3c5ce7877db4a67c21d7420b55308
Jille Apr 13, 2012
ef83809
Fix typo in tests expect
Jille Apr 13, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/weakref_008.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ unset($ref);
echo "done...\n";
?>
--EXPECTF--
set...
get...
unset...
done...
2 changes: 1 addition & 1 deletion wr_weakref.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static int wr_weakref_ref_release(wr_weakref_object *intern TSRMLS_DC) /* {{{ */
if (intern->valid && (intern->acquired > 0)) {
intern->acquired--;
if (intern->acquired == 0) {
// We need to register that ref so that the object doesn't get collected
// We need to unregister that ref so that the object can get collected
Z_OBJ_HANDLER_P(intern->ref, del_ref)(intern->ref TSRMLS_CC);
}
return SUCCESS;
Expand Down