Skip to content

Fix comment and test #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2012
Merged

Fix comment and test #5

merged 2 commits into from
Apr 13, 2012

Conversation

Jille
Copy link
Contributor

@Jille Jille commented Apr 13, 2012

No description provided.

colder added a commit that referenced this pull request Apr 13, 2012
@colder
Merge pull request #5 from Jille/master
b725d14 
Fix comment and test
@colder colder merged commit b725d14 into colder:master Apr 13, 2012
@colder
Copy link
Owner

colder commented Apr 13, 2012

Thanks for these!

Btw, the test you contributed (007) doesn't actually use any WeakRef :)

@Jille
Copy link
Contributor Author

Jille commented Apr 13, 2012

Whoops. I changed 'new WeakRef' into 'array' to make sure the problem was in WeakRef instead of just PHP itself. I filed a new pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jille @colder