Skip to content

Fix video links #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2024
Merged

Fix video links #130

merged 6 commits into from
Oct 13, 2024

Conversation

mikatuo
Copy link
Contributor

@mikatuo mikatuo commented Oct 2, 2024 •
edited
Loading

Fixes #116

Changes

  • use "/watch?v=..." links when opening videos
  • open videos in a new tab

Demo

image

@mikatuo mikatuo changed the title Fix videos links Fix video links Oct 2, 2024
britzl
britzl reviewed Oct 3, 2024
View reviewed changes
britzl
britzl requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about source of learnindex.json

@mikatuo mikatuo mentioned this pull request Oct 10, 2024
Merged
@mikatuo
Copy link
Contributor Author

mikatuo commented Oct 12, 2024

Tested - looks good:

image

@mikatuo mikatuo requested a review from britzl October 12, 2024 22:05
@britzl britzl merged commit c25b91f into defold:master Oct 13, 2024
@britzl
Copy link
Collaborator

britzl commented Oct 13, 2024

Thanks!

@mikatuo mikatuo deleted the fix-videos-links branch October 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl Awaiting requested review from britzl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Videos link to the wrong page
2 participants
@mikatuo @britzl