Skip to content

Fix video links #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2024
Merged

Fix video links #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce06ebc
fix video links
mikatuo Oct 2, 2024
6821a8a
open video links in a new tab
mikatuo Oct 2, 2024
544eb1d
Merge branch 'master' into fix-videos-links
mikatuo Oct 12, 2024
4a42e93
fix
mikatuo Oct 12, 2024
b2781b0
Update learnindex.json
mikatuo Oct 12, 2024
d8d50c2
fix
mikatuo Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions _includes/youtube_card.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<div class='card left compact clickable'>
<div class="center" style="padding-bottom: 1em;">
<iframe width="100%" src="{{ include.link }}" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
<iframe width="100%" src="{{ include.embed }}" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
</div>
<div>
<a href="{{ include.link }}"><h5>{{ include.title }}</h5></a>
<a href="{{ include.link }}" target="_blank"><h5>{{ include.title }}</h5></a>
{%- if include.author -%}<p style="font-size: small">{{ include.author }}</p>{%- endif -%}
<a href="{{ include.link }}"><p style="font-size: small">{{ include.description }}</p></a>
<a href="{{ include.link }}" target="_blank"><p style="font-size: small">{{ include.description }}</p></a>
</div>
</div>
2 changes: 1 addition & 1 deletion _layouts/learn.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ <h3>Videos</h3>
</div>
<div style="display: grid; grid-template-columns: repeat(auto-fit, minmax(250px, 1fr)); grid-gap: 2rem; padding: 0px;">
{%- for video in site.data.learnindex.navigation.videos limit:3 -%}
{% include youtube_card.html title=video.name description=video.description link=video.path author=video.author min-height="250px" image="/images/icons/yt_icon_rgb.svg" %}
{% include youtube_card.html title=video.name description=video.description embed=video.embed link=video.path author=video.author min-height="250px" image="/images/icons/yt_icon_rgb.svg" %}
{%- endfor -%}
</div>
<div class="row">
Expand Down
4 changes: 2 additions & 2 deletions videos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ <h3>Videos</h3>
{%- assign videos = site.data.learnindex.navigation.videos | where: "author", author -%}
<h3>{{ author }}</h3>
<div style="display: grid; grid-template-columns: repeat(auto-fit, minmax(250px, 1fr)); grid-gap: 2rem; padding: 0px;">
{%- for tutorial in videos -%}
{% include youtube_card.html title=tutorial.name description=tutorial.description link=tutorial.path author=tutorial.author min-height="250px" image="/images/icons/yt_icon_rgb.svg" %}
{%- for video in videos -%}
{% include youtube_card.html title=video.name description=video.description embed=video.embed link=video.path author=video.author min-height="250px" image="/images/icons/yt_icon_rgb.svg" %}
{%- endfor -%}
</div>
{%- endfor -%}
Expand Down