fix(dotcli): Fix error when pulling folder with parentheses #32258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...gration/src/test/java/com/dotcms/rest/api/v1/asset/AssetPathResolverImplIntegrationTest.java
Outdated
Show resolved
Hide resolved
...gration/src/test/java/com/dotcms/rest/api/v1/asset/AssetPathResolverImplIntegrationTest.java
Show resolved
Hide resolved
fabrizzio-dotCMS
approved these changes
May 28, 2025
erickgonzalez
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The code was getting the folder as an asset when it had parentheses or a special character on the name, because it was trying to do a replace on the name with the
replaceFirstfunction, which handles the first argument as a regex, so as the name has a special character (in this scenario parentheses), it was recognizing it as a regex which led to be treated as an asset, and finally throwingAsset not found errorFix
Pattern.quotewas added to handle the string as literalThis PR fixes: #32075