-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[2025/05/12] Candidate - In Flight Branch #29335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ature (#29165) * added the selection feature tests * added snapshots
* Fixed Footer not displayed at the Bottom When EmptyView in CV2 * Updated test sample with Background Color * Updated fix for CV1 * Removed unwanted changes and updated screenshot * Added comment in test sample * Updated test sample * Added snapshot for mac and WinUI * Re- Added mac snapshot * Update HeaderAndFooterShouldBeVisible.png
…h doesn't get IsVisible (=true) update from its parent (#29024) * Fixed On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent * Test case added * Test case name modified * Test case modified
…h Horizontal ItemsLayout When EmptyView is Displayed" (#28779) * Fixed the ItemsLayout issue with the EmptyView * Committed the Android snap
…thod of ICanvas called with default font (#29048) * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * Modified the test case * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * [Windows] Fix for 20419 ( Bug in ICanvas.GetStringSize when called with default font ) * Have updated the fix by creating the CanvasTextFormat instance using the ToCanvasTextFormat extension method defined in FontExtensions * Removed unused namespace references
* enabled the test case for android * added comment
…avigation (#29286) * [Windows] Fix for Carousel View doesn't scroll programmatically * Test case sample
* Fixed flaky editor test * Added scroll down again to double check * Optimized code changes and added new test snapshots * Added missing WinUI snap
* fix * enable Bugzilla31255Test * add device test * make _element a weak reference directly * fix device test * Use AssertMemoryTest in UITest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces several new test cases and feature enhancements to improve the handling and selection capabilities in CollectionView as well as to address various platform-specific UI adjustments. Key changes include:
- Addition of new test cases for issues and bug fixes (Issue19500, Issue10222, Bugzilla31255, and FlyoutPageTests).
- Enhancements and new properties in the CollectionView view model to support selection modes and events.
- Updates to various platform-specific handlers (iOS, Windows, Android) for improved UI behavior and performance.
Reviewed Changes
Copilot reviewed 56 out of 61 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/Controls/tests/TestCases.HostApp/Issues/Issue19500.cs | Added test case for iOS Editor scrolling when IsReadOnly is true. |
src/Controls/tests/TestCases.HostApp/Issues/Issue10222.cs | Added tap gesture handling for CarouselView test. |
src/Controls/tests/TestCases.HostApp/Issues/Bugzilla/Bugzilla31255.cs | Updated UI elements and page navigation logic for bug fix. |
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/Selection/*.cs | Introduced new pages and view model improvements for CollectionView selection features. |
src/Controls/tests/DeviceTests/Elements/FlyoutPage/FlyoutPageTests.cs | Added test to ensure FlyoutPage does not leak as a modal. |
src/Controls/src/Core/Platform/iOS/Extensions/FormattedStringExtensions.cs & Label.iOS.cs | Updated method signatures and calls to include explicit size parameters. |
src/Controls/src/Core/Handlers/Items2/iOS/* & ItemsViewController2.cs | Adjusted empty view layout logic and return types for better UI consistency. |
src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs | Modified scrollbar visibility settings when swipe is disabled. |
src/Controls/src/Core/Handlers/Items/Android/MauiRecyclerView.cs | Updated layout manager selection to use a helper method. |
src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs | Changed element storage from a strong reference to a weak reference to improve memory management. |
Files not reviewed (5)
- src/Controls/samples/Controls.Sample.Embedding/Resources/Styles/Styles.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewFeaturePage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/Selection/CollectionViewSelectionPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/Selection/SelectionOptionsPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue19500.xaml: Language not supported
Comments suppressed due to low confidence (3)
src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs:78
- Using a WeakReference for _element is a good approach to avoid memory leaks. Please ensure that downstream consumers of the Element property can safely handle a null value returned from GetTargetOrDefault().
public VisualElement Element => _viewHandlerWrapper.Element ?? _element?.GetTargetOrDefault();
src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs:238
- The change to use WScrollBarVisibility.Hidden instead of Disabled may alter the visual feedback for users. It would be helpful to document this UI behavior change to inform maintainers and consumers.
ScrollViewer.SetHorizontalScrollBarVisibility(ListViewBase, ItemsView.IsSwipeEnabled ? WScrollBarVisibility.Auto : WScrollBarVisibility.Hidden);
src/Controls/src/Core/Handlers/Items/Android/MauiRecyclerView.cs:579
- Ensure that the SelectLayoutManager method reliably returns the appropriate layout manager for all supported ItemsLayout cases, so that no layout issues occur in various scenarios.
SetLayoutManager(SelectLayoutManager(ItemsLayout));
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
.NET MAUI Release Notes - inflight/candidate
This document contains release notes for changes from main branch to inflight/candidate branch.
MAUI Product Fixes
Testing
Dependency Updates
No dependency updates in this release
Docs
No documentation changes in this release
Housekeeping
No housekeeping changes in this release
New Contributors
Full Changelog: main...inflight/candidate