-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Android] Fix: Modal Animation Repeats When Returning from Background 2 #29557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix: Modal Animation Repeats When Returning from Background 2 #29557
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
|
||
#pragma warning disable CS0618 // TODO: Remove when we internalize/replace MessagingCenter | ||
if (value) | ||
MessagingCenter.Send(this, CloseContextActionsSignalName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was originally intended for
maui/src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewAdapter.cs
Lines 69 to 70 in acd2a94
//TODO: MAUI | |
//MessagingCenter.Subscribe<ListViewAdapter>(this, Platform.CloseContextActionsSignalName, lva => CloseContextActions()); |
which clearly isn’t subscribing anymore.
And since ListView is about to be kicked out of the house, I’m removing it.
On the after, the first time that you reopen the app I could see an animation very fast, and after that no more. Not sure if it's something that shiuld be fixed or we can ignore. It's definitely better than before |
Thanks to @PureWeen 's suggestion, I think now animation works perfectly in all cases. anim.mov |
Yeah I noticed that too.. But i don't think it's related to animation we set.. because same thing can be seen if we do PushModalAsync(false) |
/azp run |
|
It seems , using |
… 2 (#29557) * [Android] clean up modalnavigationmanager * fix failing tests * Handle animation while poping * subscribe to event before showing dailog * change style's names * apply new styles * set result to tcs once dailog dismiss
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This is an alternative (and improved) approach to #28538 and #28522.
As suggested by @PureWeen, a new animation style has been added, and the previous animation logic has been cleaned up.
before_fix.mov
new_fix.mov
Issues Fixed
Fixes #28492