[2025/05/26] Candidate - In Flight Branch #29623

PureWeen · 2025-05-22T18:22:07Z

For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

Copilot

Pull Request Overview

This PR introduces new CarouselView feature pages to the TestCases.HostApp, updates the gallery pages, refines layout constraint computation in several layout classes, and adjusts handler mappings in Shell and related components in support of the inflight branch process.

Adds new XAML and code-behind pages for CarouselView options, feature, and control views.
Integrates CarouselView into the gallery and updates related animations, layout constraints, and event bindings.
Enhances unit tests (e.g., ImageSource parent clearing) and adjusts platform-specific handler mappings.

Reviewed Changes

Copilot reviewed 106 out of 106 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
CarouselViewOptionsPage.xaml	New XAML page for CarouselView options UI.
CarouselViewFeaturePage.xaml & .xaml.cs	New feature page for demonstrating CarouselView usage.
CarouselViewControlPage.xaml & .xaml.cs	Implements CarouselView control with associated event handlers and binding integration.
CorePageView.cs	Registers the new CarouselView feature in the gallery page list.
ImageSourceTests.cs	Introduces a unit test to verify parent clearing when the image source is updated.
AssemblyInfo.cs	Adds internals visibility for Maui.UnitTests.
ModalNavigationManager.Android.cs	Refines modal navigation animation and dismissal handling.
FormattedStringExtensions.cs	Updates font span creation to use an updated font size retrieval method.
VerticalStackLayout.cs, StackLayout.cs, HorizontalStackLayout.cs, Grid.cs	Adds ComputeConstraintForView implementations to support fixed layout constraints.
ImageElement.cs	Modifies event attachment to use pattern matching for null checks.
ShellHandler.cs & ShellHandler.Windows.cs	Maps new Shell properties related to Flyout background images.
CarouselViewHandler.Windows.cs	Calls UpdateItemsSource for CarouselView template updates.
SearchHandlerAppearanceTracker.cs	Adjusts background color assignment on iOS search bar.
ShellToolbarTracker.cs	Updates toolbar item tint color handling with a new helper method.

src/Controls/tests/Core.UnitTests/ImageSourceTests.cs

src/Controls/src/Core/Handlers/Shell/ShellHandler.cs

sheiksyedm · 2025-05-27T06:54:36Z

@kubaflo The following tests failed due to changes introduced in PR #29469

Bugzilla41415Test
KeepEditorCursorAboveKeyboardInScrollView

sheiksyedm · 2025-05-27T07:36:58Z

@kubaflo The BackgroundGradientsShouldRenderCorrectly test failed due to changes introduced in PR #20205

kubaflo · 2025-05-27T08:57:26Z

@sheiksyedm I've created PRs which fix these problems

sheiksyedm · 2025-05-29T10:31:36Z

@kubaflo This device test failed due to changes introduced in PR #29469, even after including the refix from that PR #29688.

rmarinho · 2025-05-30T00:31:12Z

/rebase

…nges (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated

* Fixed picker title's color * Update PickerExtensions.cs

* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…ion - 18 (#28033) * Enabled CollectionViewUITests * Updated Issue Link * Addressed Feedbacks * Updated changes * Added images * Revert Changes * Changes updated * updated changes * Changes updated * Changes updated * Reverted Issue18896 * Changes updated * Reverted issue1583_1 * Reverted Issue18896

* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test

* [iOS] ScrollView content offset RTL fix * Added a UITest

…dding value for the label (#29163) * [Windows] Fix for 6387 ( Negative Padding values fail ). * [Windows] Fix for 6387 ( Negative Padding values fail ). * Have added Test case * Added a comment line explaining the assignment of zero when a padding value is negative * Have modified the test case

* Enhance debugging in ViewHandler.cs Added System.Diagnostics for debugging support. Introduced DebuggerDisplay attribute to ViewHandler class and added GetDebuggerDisplay method to improve object state visibility during debugging. * Update src/Core/src/Handlers/View/ViewHandler.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Copilot <[email protected]>

* Fixed incorrect width and height * Updated test sample * Updated method name * Update shared test sample * Given width and height request for graphicsview in sample * Added snapshots

* Fixed the item template dynamic changes * Added a test case * Added test case and added snapshots * committed the image * committed the image

* re-enabled the test for android * modified test case * Update src/Controls/tests/TestCases.HostApp/Issues/CarouselViewLoopNoFreeze.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>

) * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for Flyout Background Image * Test case sample for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * Updated Test sample * Changed test sample and added snapshots for android and iOS * BackgroundImage set Snapshot for windows and mac * BackgroundImage set Null Snapshot for windows and mac

… 2 (#29557) * [Android] clean up modalnavigationmanager * fix failing tests * Handle animation while poping * subscribe to event before showing dailog * change style's names * apply new styles * set result to tcs once dailog dismiss

…27575) * fixed shell items click issue * fix for shell items click issue * fix for flyoutitem in the overflow menu is not fully intractable * fix for flyoutitem in the overflow menu is not fully intractable * Update Issue6784.cs Removed test case fails on Windows * added new image * added new ci image

…ly - fix (#29561) * [Android] The number of SearchHandler toolbar item increases abnormally - fix * Added a UI test * Create NumberOfToolbarItemsShouldNotIncrease.png

…ge's Source to Local File Paths (#28405) * add extra condition * use _sourceCancellation

* Added the CarouselView FeatureMatrix to the hostapp * added test cases * added test cases * updated changes * updated the test cases * modified changes * added issue link * updated layout * updated changes * updated test cases * Changes updated * changes updated * Fix Formatting * Changes updated --------- Co-authored-by: nivetha-nagalingam <[email protected]> Co-authored-by: LogishaSelvarajSF4525 <[email protected]>

…29604) * Added test cases to ensure menuflyoutitem commands * code optimization * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20685.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>

…o the Bottom Tab Icon (#29317) * Fixed the FontImageSource Icon color issues on the BottomNavigationView Tabs * Committed the test sample and case * Added comment over the fix * Remove unnecessary space

…ckground 2 (#29640) * Revert "[Android] Fix: Modal Animation Repeats When Returning from Background 2 (#29557)" * Clean Up - Remove MessagingCenter related stuff

* Fixed Test case failure in PR 29469 - [2025/05/26] * Fixed Test case failure in PR 29469 - [2025/05/26]

* CollectionView drag changes on Mac * Mac drag changes

Copilot AI review requested due to automatic review settings May 22, 2025 18:22

PureWeen requested a review from a team as a code owner May 22, 2025 18:22

PureWeen requested review from StephaneDelcroix and tj-devel709 May 22, 2025 18:22

PureWeen added this to the .NET 9 SR8 milestone May 22, 2025

PureWeen added this to MAUI SDK Ongoing May 22, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing May 22, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing May 22, 2025

Copilot AI reviewed May 22, 2025

View reviewed changes

src/Controls/tests/Core.UnitTests/ImageSourceTests.cs Show resolved Hide resolved

src/Controls/src/Core/Handlers/Shell/ShellHandler.cs Show resolved Hide resolved

LogishaSelvarajSF4525 mentioned this pull request May 23, 2025

Fixed Test case failure in PR 29623 - [2025/05/26] Candidate #29636

Merged

This was referenced May 27, 2025

Fixed Test case failure in PR 20205 - [2025/05/26] #29686

Merged

[Testing][iOS] Updated PickerTitleShouldBeRed snapshot #29684

Closed

Fixed Test case failure in PR 29469 - [2025/05/26] #29688

Merged

kubaflo mentioned this pull request May 29, 2025

Fixed Test case failure in PR 29469 - [2025/05/26] #29735

Merged

NafeelaNazhir and others added 11 commits May 30, 2025 00:31

[Testing] Feature Matrix UITest Cases for CollectionView Dynamic cha…

4b9ceef

…nges (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated

Remove (#29476)

f5e12ee

[iOS] Fixed picker title's color (#20205)

753e12d

* Fixed picker title's color * Update PickerExtensions.cs

[iOS] Setting background color on the Searchbar - fix (#23355)

aac1ddc

* [iOS] Setting background color on the Searchbar (#23325) * Added a test category * Ui tests * Update SearchHandlerAppearanceTracker.cs * Update Issue23325Test.png

Clear Parent on old image source (#29481)

a5821bc

[create-pull-request] automated change (#29505)

0b6aad7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[Android] Fix WebView Navigated is fired when source is null (#29234)

2e9c6a9

* Don't LoadUrl call when source is null * Add UI Test * remove space * Update UI Test

Set result to tcs when user cancels (#29498)

4a54772

[housekeeping] Automated PR to fix formatting errors on inflight/current

09348a6

[iOS] ScrollView content offset RTL - fix (#29469)

00851b6

* [iOS] ScrollView content offset RTL fix * Added a UITest

SyedAbdulAzeemSF4852 and others added 27 commits May 30, 2025 00:31

[housekeeping] Automated PR to fix formatting errors on inflight/current

f80142a

Compute LayoutConstraints on new *StackLayout and Grid (#28931)

4aa0858

[housekeeping] Automated PR to fix formatting errors on inflight/current

19fca33

Fixed Maui.Graphics GetStringSize Inverts Width and Height (#29574)

26b6ed8

* Fixed incorrect width and height * Updated test sample * Updated method name * Update shared test sample * Given width and height request for graphicsview in sample * Added snapshots

Fix CarouselView ItemTemplate Runtime Updates (#29546)

bc5d075

* Fixed the item template dynamic changes * Added a test case * Added test case and added snapshots * committed the image * committed the image

[housekeeping] Automated PR to fix formatting errors on inflight/current

aa7db69

[housekeeping] Automated PR to fix formatting errors on inflight/current

2b44883

Fix Build issue in inflight/Current (#29614)

a8170a7

[Android] The number of SearchHandler toolbar item increases abnormal…

4d11070

…ly - fix (#29561) * [Android] The number of SearchHandler toolbar item increases abnormally - fix * Added a UI test * Create NumberOfToolbarItemsShouldNotIncrease.png

[Android] Fix: Prevent Duplicate MapSource Invocations on setting Ima…

82aa099

…ge's Source to Local File Paths (#28405) * add extra condition * use _sourceCancellation

Fixed the label span issue. (#28851)

3e6ffa6

[Android] Fix for the FontImageSource color is not applied properly t…

ca91b22

…o the Bottom Tab Icon (#29317) * Fixed the FontImageSource Icon color issues on the BottomNavigationView Tabs * Committed the test sample and case * Added comment over the fix * Remove unnecessary space

Fixed Test case failure in PR 20205 - [2025/05/26] (#29686)

b020918

[Revert][Android] Fix: Modal Animation Repeats When Returning from Ba…

008dfb4

…ckground 2 (#29640) * Revert "[Android] Fix: Modal Animation Repeats When Returning from Background 2 (#29557)" * Clean Up - Remove MessagingCenter related stuff

Fixed Test case failure in PR 29623 - [2025/05/26] Candidate (#29636)

00118bd

Fixed Test case failure in PR 29469 - [2025/05/26] (#29688)

71a47f4

* Fixed Test case failure in PR 29469 - [2025/05/26] * Fixed Test case failure in PR 29469 - [2025/05/26]

[Catalyst] Click-Dragging Behavior in CollectionView (#29616)

c768997

* CollectionView drag changes on Mac * Mac drag changes

Fix iOS Label being truncated when using Padding (#29031)

5dcbaed

Fixed Test case failure in PR 29469 - [2025/05/26] (#29735)

44c7fad

github-actions bot force-pushed the inflight/candidate branch from 3abc4ba to 44c7fad Compare May 30, 2025 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[2025/05/26] Candidate - In Flight Branch #29623

[2025/05/26] Candidate - In Flight Branch #29623

PureWeen commented May 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sheiksyedm commented May 27, 2025 •

edited

Loading

Uh oh!

sheiksyedm commented May 27, 2025

Uh oh!

kubaflo commented May 27, 2025 •

edited

Loading

Uh oh!

sheiksyedm commented May 29, 2025

Uh oh!

rmarinho commented May 30, 2025

Uh oh!

Uh oh!

[2025/05/26] Candidate - In Flight Branch #29623

Are you sure you want to change the base?

[2025/05/26] Candidate - In Flight Branch #29623

Conversation

PureWeen commented May 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

sheiksyedm commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheiksyedm commented May 27, 2025

Uh oh!

kubaflo commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sheiksyedm commented May 29, 2025

Uh oh!

rmarinho commented May 30, 2025

Uh oh!

Uh oh!

sheiksyedm commented May 27, 2025 •

edited

Loading

kubaflo commented May 27, 2025 •

edited

Loading