Skip to content

[2025/05/26] Candidate - In Flight Branch #29623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4b9ceef
[Testing] Feature Matrix UITest Cases for CollectionView Dynamic cha…
NafeelaNazhir May 13, 2025
f5e12ee
Remove (#29476)
MartyIX May 13, 2025
753e12d
[iOS] Fixed picker title's color (#20205)
kubaflo May 13, 2025
aac1ddc
[iOS] Setting background color on the Searchbar - fix (#23355)
kubaflo May 13, 2025
a5821bc
Clear Parent on old image source (#29481)
PureWeen May 14, 2025
0b6aad7
[create-pull-request] automated change (#29505)
github-actions[bot] May 15, 2025
9e6dd7e
[Testing] Enabling more UI Tests by removing platform specific condit…
NafeelaNazhir May 15, 2025
2e9c6a9
[Android] Fix WebView Navigated is fired when source is null (#29234)
bhavanesh2001 May 15, 2025
4a54772
Set result to tcs when user cancels (#29498)
bhavanesh2001 May 15, 2025
09348a6
[housekeeping] Automated PR to fix formatting errors on inflight/current
github-actions[bot] May 15, 2025
00851b6
[iOS] ScrollView content offset RTL - fix (#29469)
kubaflo May 15, 2025
7c7f85d
[Windows] Fix for ArgumentException thrown when setting a negative pa…
SyedAbdulAzeemSF4852 May 16, 2025
f80142a
[housekeeping] Automated PR to fix formatting errors on inflight/current
github-actions[bot] May 16, 2025
14bf504
Enhance debugging in ViewHandler.cs (#29538)
pictos May 19, 2025
4aa0858
Compute LayoutConstraints on new *StackLayout and Grid (#28931)
albyrock87 May 20, 2025
19fca33
[housekeeping] Automated PR to fix formatting errors on inflight/current
github-actions[bot] May 20, 2025
26b6ed8
Fixed Maui.Graphics GetStringSize Inverts Width and Height (#29574)
Dhivya-SF4094 May 21, 2025
bc5d075
Fix CarouselView ItemTemplate Runtime Updates (#29546)
Shalini-Ashokan May 21, 2025
fd8a326
[Testing] Re-Enabled UI Test - Issue12574Test (#29436)
TamilarasanSF4853 May 21, 2025
5b7012d
[Windows] Fixed Shell flyout background image does not displayed (#28…
SubhikshaSf4851 May 21, 2025
aa7db69
[housekeeping] Automated PR to fix formatting errors on inflight/current
github-actions[bot] May 21, 2025
bd118f6
[Android] Fix: Modal Animation Repeats When Returning from Background…
bhavanesh2001 May 21, 2025
2b44883
[housekeeping] Automated PR to fix formatting errors on inflight/current
github-actions[bot] May 21, 2025
afd836a
[Windows] Fix for FlyoutItem in overflow menu not fully interactable …
TamilarasanSF4853 May 22, 2025
a8170a7
Fix Build issue in inflight/Current (#29614)
bhavanesh2001 May 22, 2025
4d11070
[Android] The number of SearchHandler toolbar item increases abnormal…
kubaflo May 22, 2025
82aa099
[Android] Fix: Prevent Duplicate MapSource Invocations on setting Ima…
bhavanesh2001 May 22, 2025
3e6ffa6
Fixed the label span issue. (#28851)
NanthiniMahalingam May 22, 2025
88c0db6
[Testing] Feature Matrix UITest Cases for CarouselView (#29548)
NafeelaNazhir May 22, 2025
e4a6709
[Testing] Added UITest for MenuFlyoutItem Clicked/Command delegate (#…
anandhan-rajagopal May 22, 2025
ca91b22
[Android] Fix for the FontImageSource color is not applied properly t…
Ahamed-Ali May 23, 2025
b020918
Fixed Test case failure in PR 20205 - [2025/05/26] (#29686)
kubaflo May 27, 2025
008dfb4
[Revert][Android] Fix: Modal Animation Repeats When Returning from Ba…
bhavanesh2001 May 27, 2025
00118bd
Fixed Test case failure in PR 29623 - [2025/05/26] Candidate (#29636)
LogishaSelvarajSF4525 May 28, 2025
71a47f4
Fixed Test case failure in PR 29469 - [2025/05/26] (#29688)
kubaflo May 28, 2025
c768997
[Catalyst] Click-Dragging Behavior in CollectionView (#29616)
Tamilarasan-Paranthaman May 28, 2025
5dcbaed
Fix iOS Label being truncated when using Padding (#29031)
albyrock87 May 29, 2025
44c7fad
Fixed Test case failure in PR 29469 - [2025/05/26] (#29735)
kubaflo May 29, 2025
9877ebc
added snapshot (#29742)
LogishaSelvarajSF4525 May 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Windows] Fix for FlyoutItem in overflow menu not fully interactable (#…
…27575)

* fixed shell items click issue

* fix for shell items click issue

* fix for flyoutitem in the overflow menu is not fully intractable

* fix for flyoutitem in the overflow menu is not fully intractable

* Update Issue6784.cs

Removed test case fails on Windows

* added new image

* added new ci image
  • Loading branch information
TamilarasanSF4853 authored and rmarinho committed May 30, 2025
commit afd836af03b9cdb2b90b8cc29d7ce62bf61ac677
40 changes: 40 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue23803.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
namespace Maui.Controls.Sample.Issues
{
[Issue(IssueTracker.Github, 23803, "FlyoutItem in overflow menu not fully interactable", PlatformAffected.UWP)]
public partial class Issue23803 : TestShell
{
protected override void Init()
{
CreateTabContent();
}

private void CreateTabContent()
{
var flyoutItem = new FlyoutItem { Title = "Header" };
for (int i = 1; i <= 20; i++)
{
var contentPage = new ContentPage
{
Content = new Button
{
Text = $"Button_{i}",
AutomationId = $"Button{i}",
FontSize = 24,
HorizontalOptions = LayoutOptions.Center,
VerticalOptions = LayoutOptions.Center
}
};

var shellContent = new ShellContent
{
Title = $"Tab{i}",
Content = contentPage
};

flyoutItem.Items.Add(shellContent);
}
this.FlyoutBehavior = FlyoutBehavior.Disabled;
this.Items.Add(flyoutItem);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues
{
public class Issue23803 : _IssuesUITest
{
public override string Issue => "FlyoutItem in overflow menu not fully interactable";

public Issue23803(TestDevice device)
: base(device)
{ }

[Test]
[Category(UITestCategories.Shell)]
public void VerifyClickAroundOverflowMenuItem()
{
App.Tap("More");
#if WINDOWS
var rect = App.WaitForElement("Tab18").GetRect();
App.TapCoordinates(rect.X + 80, rect.Y + 15);
App.WaitForElement("Button18");
#else
App.WaitForElement("Tab6");
App.Tap("Tab6");
App.WaitForElement("Button6");
#endif
}
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#if TEST_FAILS_ON_WINDOWS // When using App.Tap to interact with tab items which placed in the more section, the action targets the corner of the tabs, Line No 24
// which doesn't trigger navigation on Windows. Windows requires tapping directly on the tab title text.
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down Expand Up @@ -61,4 +59,3 @@ public void TwoMoreControllerDoesNotShowEditButton()
#endif
}
}
#endif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.ComponentModel;
using System.Runtime.CompilerServices;
using Microsoft.UI.Xaml.Controls;
using Microsoft.UI.Xaml.Media;
using WBrush = Microsoft.UI.Xaml.Media.Brush;
using WIconElement = Microsoft.UI.Xaml.Controls.IconElement;

Expand Down Expand Up @@ -110,7 +111,7 @@ public WBrush? Foreground

public WBrush? Background
{
get => IsSelected ? SelectedBackground : UnselectedBackground;
get => (IsSelected ? SelectedBackground : UnselectedBackground) ?? new SolidColorBrush(Microsoft.UI.Colors.Transparent); //The Background color is set to null since both SelectedBackground and UnselectedBackground return null. Adding a default transparent background ensures it is never null, preventing rendering inconsistencies.
}

public object? Data
Expand Down