[net10.0, Testing] Fix LabelFeatureTests Screenshot Issue on Windows #30137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the LabelFeatureTests to address the screenshot issue on Windows by explicitly tapping the MainLabel to remove the keyboard focus indicator (black box) before verifying screenshots.
- Added wait and tap steps for MainLabel in four test cases to ensure a clean screenshot.
Comment on lines
+527
to
+528
| App.WaitForElement(MainLabel); | ||
| App.Tap(MainLabel); |
There was a problem hiding this comment.
[nitpick] The calls to 'WaitForElement(MainLabel)' and 'Tap(MainLabel)' are repeated in each test case. Consider extracting these steps into a helper method to improve maintainability and reduce duplication in your test suite.
Suggested change
| App.WaitForElement(MainLabel); | |
| App.Tap(MainLabel); | |
| WaitForAndTapMainLabel(); |
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
changed the title
jsuarezruiz
approved these changes
Jun 24, 2025
rmarinho
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the test cases for verifying label features in LabelFeatureTests.cs by ensuring that the main label is explicitly tapped before taking a screenshot. This interaction removes the keyboard navigation focus indicator (black box) that may appear if a control is previously focused via keyboard. By tapping another region (the label), the black box disappears, resulting in more reliable and cleaner screenshots for verification.
Enhancements to label feature test cases:
VerifyLabelWithTextAndFontSize: Added steps to wait for and tap onMainLabelbefore verifying the screenshot.VerifyLabelWithTextAndCharacterSpacing: Added steps to wait for and tap onMainLabelbefore verifying the screenshot.VerifyLabelWithTextAndMaxlines: Added steps to wait for and tap onMainLabelbefore verifying the screenshot.VerifyLabelWithTextWhenLineHeight: Added steps to wait for and tap onMainLabelbefore verifying the screenshot.