Skip to content

[net10.0, Testing] Fix LabelFeatureTests Screenshot Issue on Windows #30137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[net10.0, Testing] Fix LabelFeatureTests Screenshot Issue on Windows #30137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/LabelFeatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,8 @@ public void VerifyLabelWithTextAndFontSize()
App.EnterText(FontSizeEntry, "24");
App.WaitForElement(Apply);
App.Tap(Apply);
App.WaitForElement(MainLabel);
App.Tap(MainLabel);
Comment on lines +527 to +528
Copy link
Preview

Copilot AI Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The calls to 'WaitForElement(MainLabel)' and 'Tap(MainLabel)' are repeated in each test case. Consider extracting these steps into a helper method to improve maintainability and reduce duplication in your test suite.

Suggested change
App.WaitForElement(MainLabel);
App.Tap(MainLabel);
WaitForAndTapMainLabel();

Copilot uses AI. Check for mistakes.

VerifyScreenshot();
}

Expand Down Expand Up @@ -573,6 +575,8 @@ public void VerifyLabelWithTextAndCharacterSpacing()
App.EnterText(CharacterSpacingEntry, "3");
App.WaitForElement(Apply);
App.Tap(Apply);
App.WaitForElement(MainLabel);
App.Tap(MainLabel);
VerifyScreenshot();
}

Expand Down Expand Up @@ -713,6 +717,8 @@ public void VerifyLabelWithTextAndMaxlines()
App.EnterText(MaxLinesEntry, "1");
App.WaitForElement(Apply);
App.Tap(Apply);
App.WaitForElement(MainLabel);
App.Tap(MainLabel);
VerifyScreenshot();
}

Expand All @@ -730,6 +736,8 @@ public void VerifyLabelWithTextWhenLineHeight()
App.EnterText(LineHeightEntry, "2");
App.WaitForElement(Apply);
App.Tap(Apply);
App.WaitForElement(MainLabel);
App.Tap(MainLabel);
VerifyScreenshot();
}

Expand Down
Loading