Fix Changing Shell.NavBarIsVisible does not update the nav bar #30339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 138797f.
|
Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
Jul 1, 2025
| public void VerifyNavBarStatusAtInitialLoading() | ||
| { | ||
| App.WaitForElement("NavBarToggleButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots. Running a build.
There was a problem hiding this comment.
Snapshots already available in the latest build. Could you commit the images?
There was a problem hiding this comment.
@jsuarezruiz , Pending snapshots has been added.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue details
Shell.NavBarIsVisibleProperty changes were only recognized during initial page loading, but not when changed at runtime.
Description of Change
Added code in OnNavBarIsVisibleChanged method to explicitly propagate property changes to child elements.
Issues Fixed
Fixes #17550
Tested the behavior in the following platforms.
iOS_WithoutFix.mov
iOS-Fix.mov