-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Changing Shell.NavBarIsVisible does not update the nav bar #30339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix Changing Shell.NavBarIsVisible does not update the nav bar #30339
Conversation
This reverts commit 138797f.
Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
public void VerifyNavBarStatusAtInitialLoading() | ||
{ | ||
App.WaitForElement("NavBarToggleButton"); | ||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshots. Running a build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz , Pending snapshots has been added.
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue details
Shell.NavBarIsVisibleProperty changes were only recognized during initial page loading, but not when changed at runtime.
Description of Change
Added code in OnNavBarIsVisibleChanged method to explicitly propagate property changes to child elements.
Issues Fixed
Fixes #17550
Tested the behavior in the following platforms.
iOS_WithoutFix.mov
iOS-Fix.mov