-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Changing Shell.NavBarIsVisible does not update the nav bar #30339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
devanathan-vaithiyanathan
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
devanathan-vaithiyanathan:fix-17550
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
138797f
fix added
devanathan-vaithiyanathan 397a2e8
Revert "fix added"
devanathan-vaithiyanathan 2f47fee
Merge branch 'dotnet:main' into main
devanathan-vaithiyanathan 465905d
fix added
devanathan-vaithiyanathan 5b9d369
test added
devanathan-vaithiyanathan a4b9395
snapshot added
devanathan-vaithiyanathan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+29.3 KB
...estCases.Android.Tests/snapshots/android/VerifyNavBarStatusAtInitialLoading.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25.1 KB
...tests/TestCases.Android.Tests/snapshots/android/VerifyNavBarStatusAtRuntime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
namespace Maui.Controls.Sample.Issues; | ||
|
||
[Issue(IssueTracker.Github, 17550, "Changing Shell.NavBarIsVisible does not update the nav bar on Mac / iOS", | ||
PlatformAffected.UWP)] | ||
public class Issue17550 : TestShell | ||
{ | ||
Button _toggleButton; | ||
|
||
protected override void Init() | ||
{ | ||
// Create a toggle button similar to the one in SandboxShell.xaml | ||
_toggleButton = new Button | ||
{ | ||
Text = Shell.GetNavBarIsVisible(this) ? "Hide NavBar" : "Show NavBar", | ||
HeightRequest = 50, | ||
WidthRequest = 150, | ||
AutomationId = "NavBarToggleButton", | ||
HorizontalOptions = LayoutOptions.Center, | ||
VerticalOptions = LayoutOptions.Center | ||
}; | ||
|
||
_toggleButton.Clicked += OnNavBarToggleButtonClicked; | ||
|
||
// Add the button to a content page in the shell | ||
Items.Add(new ShellContent | ||
{ | ||
Content = new ContentPage | ||
{ | ||
Title = "Home", | ||
Content = new StackLayout | ||
{ | ||
Children = | ||
{ | ||
new Label | ||
{ | ||
Text = "Toggle NavBar visibility", | ||
HorizontalOptions = LayoutOptions.Center | ||
}, | ||
_toggleButton | ||
}, | ||
VerticalOptions = LayoutOptions.Center | ||
} | ||
} | ||
}); | ||
} | ||
|
||
void OnNavBarToggleButtonClicked(object sender, EventArgs e) | ||
{ | ||
// Toggle the NavBar visibility | ||
bool isCurrentlyVisible = Shell.GetNavBarIsVisible(this); | ||
bool newVisibility = !isCurrentlyVisible; | ||
Shell.SetNavBarIsVisible(this, newVisibility); | ||
|
||
// Update the button text to reflect the new state | ||
_toggleButton.Text = newVisibility ? "Hide NavBar" : "Show NavBar"; | ||
} | ||
} |
Binary file added
BIN
+10.4 KB
.../tests/TestCases.Mac.Tests/snapshots/mac/VerifyNavBarStatusAtInitialLoading.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.42 KB
...ontrols/tests/TestCases.Mac.Tests/snapshots/mac/VerifyNavBarStatusAtRuntime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 28 additions & 0 deletions
28
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17550.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
using NUnit.Framework; | ||
using NUnit.Framework.Legacy; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
public class Issue17550 : _IssuesUITest | ||
{ | ||
public Issue17550(TestDevice device) : base(device) { } | ||
public override string Issue => "Changing Shell.NavBarIsVisible does not update the nav bar on Mac / iOS"; | ||
|
||
[Test, Order(1)] | ||
[Category(UITestCategories.Shell)] | ||
public void VerifyNavBarStatusAtInitialLoading() | ||
{ | ||
App.WaitForElement("NavBarToggleButton"); | ||
VerifyScreenshot(); | ||
} | ||
|
||
[Test, Order(2)] | ||
[Category(UITestCategories.Shell)] | ||
public void VerifyNavBarStatusAtRuntime() | ||
{ | ||
App.WaitForElement("NavBarToggleButton"); | ||
App.Tap("NavBarToggleButton"); | ||
VerifyScreenshot(); | ||
} | ||
} |
Binary file added
BIN
+8.85 KB
.../TestCases.WinUI.Tests/snapshots/windows/VerifyNavBarStatusAtInitialLoading.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.07 KB
...s/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyNavBarStatusAtRuntime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+32.6 KB
.../tests/TestCases.iOS.Tests/snapshots/ios/VerifyNavBarStatusAtInitialLoading.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+31.7 KB
...ontrols/tests/TestCases.iOS.Tests/snapshots/ios/VerifyNavBarStatusAtRuntime.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshots. Running a build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz , Pending snapshots has been added.