Skip to content

[testimg] Ignore net10 multiprject test #30355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 1, 2025

Description of Change

Ignore failing test for issue #30351

@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 14:47
@rmarinho rmarinho requested a review from a team as a code owner July 1, 2025 14:47
@rmarinho rmarinho added the area-testing Unit tests, device tests label Jul 1, 2025
@rmarinho rmarinho merged commit 27fada9 into net10.0 Jul 1, 2025
1 check passed
@rmarinho rmarinho deleted the ignore-net10-test branch July 1, 2025 14:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables a failing test related to issue #30351.

  • Disabled two failing test cases using comments
  • Added a TODO note to re-enable the tests once the issue is fixed

Comment on lines +9 to +11
//TODO: Reenable when we have a fix for the issue https://github.com/dotnet/maui/issues/30351
// [TestCase("Debug", "MultiProject@Symbol & More")]
// [TestCase("Release", "MultiProject@Symbol & More")]
Copy link
Preview

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the NUnit [Ignore] attribute with an appropriate message (e.g., [Ignore("Issue #30351")]) instead of commenting out test cases. This approach maintains test metadata and improves visibility of skipped tests.

Suggested change
//TODO: Reenable when we have a fix for the issue https://github.com/dotnet/maui/issues/30351
// [TestCase("Debug", "MultiProject@Symbol & More")]
// [TestCase("Release", "MultiProject@Symbol & More")]
[Test]
[TestCase("Debug", "MultiProject@Symbol & More")]
[TestCase("Release", "MultiProject@Symbol & More")]
[Ignore("Issue https://github.com/dotnet/maui/issues/30351: Reenable when fixed.")]

Copilot uses AI. Check for mistakes.

@rmarinho
Copy link
Member Author

rmarinho commented Jul 1, 2025

/backport to release/10.0.1xx-preview6

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Started backporting to release/10.0.1xx-preview6: https://github.com/dotnet/maui/actions/runs/16002701237

rmarinho added a commit that referenced this pull request Jul 2, 2025
This reverts commit 27fada9, reversing
changes made to 85e17c4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant