Skip to content

[testimg] Ignore net10 multiprject test #30355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ public class MultiProjectTemplateTest : BaseTemplateTests
[Test]
[TestCase("Debug", "simplemulti")]
[TestCase("Release", "simplemulti")]
[TestCase("Debug", "MultiProject@Symbol & More")]
[TestCase("Release", "MultiProject@Symbol & More")]
//TODO: Reenable when we have a fix for the issue https://github.com/dotnet/maui/issues/30351
// [TestCase("Debug", "MultiProject@Symbol & More")]
// [TestCase("Release", "MultiProject@Symbol & More")]
Comment on lines +9 to +11
Copy link
Preview

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the NUnit [Ignore] attribute with an appropriate message (e.g., [Ignore("Issue #30351")]) instead of commenting out test cases. This approach maintains test metadata and improves visibility of skipped tests.

Suggested change
//TODO: Reenable when we have a fix for the issue https://github.com/dotnet/maui/issues/30351
// [TestCase("Debug", "MultiProject@Symbol & More")]
// [TestCase("Release", "MultiProject@Symbol & More")]
[Test]
[TestCase("Debug", "MultiProject@Symbol & More")]
[TestCase("Release", "MultiProject@Symbol & More")]
[Ignore("Issue https://github.com/dotnet/maui/issues/30351: Reenable when fixed.")]

Copilot uses AI. Check for mistakes.

public void BuildMultiProject(string config, string projectName)
{
var projectDir = Path.Combine(TestDirectory, projectName);
Expand Down
Loading