Bugfix user_inputs side effect in RANKED_DICTIONARIES #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think there is a side effect bug with user_inputs in matching.omnimatch().
If zxcvbn.zxcvbn() is called once with a user_inputs list, RANKED_DICTIONARIES will still contains given user_inputs for all following zxcvbn's calls without a user_inputs given.
The 1st commit is a failing test illustrating the bug, the 2nd is the bugfix proposal.