Skip to content

Bugfix user_inputs side effect in RANKED_DICTIONARIES #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yweber
Copy link

@yweber yweber commented May 7, 2025

Hi,

I think there is a side effect bug with user_inputs in matching.omnimatch().

If zxcvbn.zxcvbn() is called once with a user_inputs list, RANKED_DICTIONARIES will still contains given user_inputs for all following zxcvbn's calls without a user_inputs given.

The 1st commit is a failing test illustrating the bug, the 2nd is the bugfix proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant