-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Patch for Lucene bug 14857 #130254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for Lucene bug 14857 #130254
Conversation
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Hi @benwtrent, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth considering porting the testAdvanceAdverseShallow test here for now or creating some similar test. And seems like Adrien's comment on the NO_MORE_DOCS check from the Lucene PR is applicable here as well.
otherwise lgtm
Basically, advanceShallow for knn queries can flip back from hitting NO_MORE_DOCS to a valid doc ID again. This can cause search higher level queries to flip back and forth breaking assumptions and causing a CPU core to be locked up in-definitely (until server reboot).
Applies the fix provided here, but requires gathering score docs again: apache/lucene#14858
closes: #130239