Email display subject instead of whole email #548

miha-yy · 2025-07-08T05:32:46Z

Summary by CodeRabbit

New Features
- Enhanced chat input to display a simplified email subject preview (e.g., "@(Subject)") when composing messages with email content.
- Chat input now visually distinguishes email-related content for easier recognition.
Improvements
- The chat input area now dynamically switches between the simplified display and editable input based on user focus.
- Added utility support for extracting and formatting email subjects within chat inputs.

vercel · 2025-07-08T05:32:50Z

@miha-yy is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-07-08T05:32:52Z

Walkthrough

The changes introduce a new utility module for formatting email data for chat input display, enhance the chat input component to support a distinct, formatted display value, and propagate this value from the chat UI to the input. Minor documentation and import updates are made in the assistant chat-related files.

Changes

File(s)	Change Summary
apps/web/utils/email-display.ts	New module with functions for extracting and formatting email subject for chat display.
apps/web/components/assistant-chat/multimodal-input.tsx	Added optional `displayValue` prop, internal editing state, and logic to show formatted value in textarea.
apps/web/components/assistant-chat/chat.tsx	Uses new display utility to generate and pass `displayValue` prop to input component.
apps/web/app/(app)/[emailAccountId]/assistant/FixWithChat.tsx	Added unused import of display utility and a clarifying comment in the input setter callback.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ChatUI
    participant MultimodalInput
    participant EmailDisplayUtils

    User->>ChatUI: Types or selects input
    ChatUI->>EmailDisplayUtils: createDisplayValueForInput(input)
    EmailDisplayUtils-->>ChatUI: Returns formatted display value
    ChatUI->>MultimodalInput: Passes input and displayValue
    MultimodalInput->>User: Shows displayValue (if not editing) or input (if editing)

Possibly related PRs

Use chat fix #462: Refactors FixWithChat.tsx to handle optional setInput and introduces navigation fallback and a new RuleMismatch component, indicating both PRs modify the same component.

Poem

In the warren where emails flow,
A subject line now steals the show.
With "@(Subject)" shining bright,
The chat feels tidy, just right!
Rabbits tap and hop with glee,
For clearer chats and clarity. 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(app)/[emailAccountId]/assistant/FixWithChat.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/components/assistant-chat/chat.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/components/assistant-chat/multimodal-input.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

1 others

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

CLAassistant · 2025-07-08T05:32:52Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (3)

apps/web/utils/email-display.ts (1)
15-24: Consider making email pattern detection more robust.

The current string matching approach is quite rigid and may not handle variations in email formatting. Consider using a more flexible approach or documenting the expected input format.

Apply this diff to make the detection more robust:
export function hasEmailData(input: string): boolean {
-  // Check if input contains email-related patterns
-  return (
-    input.includes("*From*:") ||
-    input.includes("*Subject*:") ||
-    input.includes("*Content*:") ||
-    input.includes("Email details:") ||
-    input.includes("Current rule applied:")
-  );
+  // Check if input contains email-related patterns (case-insensitive)
+  const patterns = [
+    /\*From\*:/i,
+    /\*Subject\*:/i,
+    /\*Content\*:/i,
+    /Email details:/i,
+    /Current rule applied:/i
+  ];
+  return patterns.some(pattern => pattern.test(input));
}
apps/web/app/(app)/[emailAccountId]/assistant/FixWithChat.tsx (1)
27-27: Remove unused import.

The createEmailDisplayValue function is imported but never used in this file. This creates unnecessary code clutter.

Apply this diff to remove the unused import:
-import { createEmailDisplayValue } from "@/utils/email-display";
apps/web/components/assistant-chat/multimodal-input.tsx (1)
98-107: Consider edge cases in focus/blur handling.

The focus/blur logic looks correct but may have edge cases. Consider what happens if displayValue becomes undefined while editing or if rapid focus/blur events occur.

Apply this diff to make the logic more robust:
const handleFocus = () => {
-  if (displayValue !== undefined && displayValue !== input) {
+  if (displayValue !== undefined && displayValue !== input && displayValue.length > 0) {
    setIsEditing(true);
  }
};

const handleBlur = () => {
-  setIsEditing(false);
+  // Use a small delay to handle rapid focus/blur events
+  setTimeout(() => setIsEditing(false), 0);
};

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 053574e and 966c217.

📒 Files selected for processing (4)

apps/web/app/(app)/[emailAccountId]/assistant/FixWithChat.tsx (2 hunks)
apps/web/components/assistant-chat/chat.tsx (3 hunks)
apps/web/components/assistant-chat/multimodal-input.tsx (7 hunks)
apps/web/utils/email-display.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

`apps/web/**/*.{ts,tsx}`: Use TypeScript with strict null checks Path aliases: U...

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier

📄 Source: CodeRabbit Inference Engine (apps/web/CLAUDE.md)