-
Notifications
You must be signed in to change notification settings - Fork 900
Email display subject instead of whole email #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
miha-yy
wants to merge
3
commits into
elie222:main
Choose a base branch
from
miha-yy:feat/email-display-subject
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import type { ParsedMessage } from "@/utils/types"; | ||
|
||
/** | ||
* Creates a simplified display value for email data in chat input | ||
* Shows "@(Subject)" format while keeping full data under the hood | ||
*/ | ||
export function createEmailDisplayValue(message: ParsedMessage): string { | ||
const subject = message.headers.subject || "No subject"; | ||
return `@(${subject})`; | ||
} | ||
|
||
/** | ||
* Checks if the input contains email data that should be displayed in simplified format | ||
*/ | ||
export function hasEmailData(input: string): boolean { | ||
// Check if input contains email-related patterns | ||
return ( | ||
input.includes("*From*:") || | ||
input.includes("*Subject*:") || | ||
input.includes("*Content*:") || | ||
input.includes("Email details:") || | ||
input.includes("Current rule applied:") | ||
); | ||
} | ||
|
||
/** | ||
* Extracts the subject from email data input for display purposes | ||
*/ | ||
export function extractSubjectFromInput(input: string): string | null { | ||
const subjectMatch = input.match(/\*Subject\*:\s*(.+?)(?:\n|$)/); | ||
return subjectMatch ? subjectMatch[1].trim() : null; | ||
} | ||
|
||
/** | ||
* Creates a display value for email-related input | ||
* Replaces the email details section with a simplified version | ||
*/ | ||
export function createDisplayValueForInput(input: string): string | undefined { | ||
if (!hasEmailData(input)) { | ||
return undefined; // Use original input | ||
} | ||
|
||
const subject = extractSubjectFromInput(input); | ||
if (!subject) { | ||
return input; // Keep original if no subject found | ||
} | ||
|
||
// Replace the email details section with simplified version | ||
const emailDetailsPattern = | ||
/Email details:\s*\*From\*:[\s\S]*?\*Content\*:[\s\S]*?(?=\n\n|\nCurrent rule|$)/; | ||
const replacement = `Email details:\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n📧 [${subject}]\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━`; | ||
|
||
const displayValue = input.replace(emailDetailsPattern, replacement); | ||
|
||
return displayValue; | ||
} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve return type consistency and regex robustness.
The function has inconsistent return types (string | undefined vs string) and uses a complex regex that might be brittle.
Apply this diff to improve consistency:
Update the function signature in the calling code to handle the consistent return type.
🤖 Prompt for AI Agents