[v3] Filter out nulls in response interceptor #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls to storage where the field doesn't exist return an array with a single null element. That throws an error when trying to access .type
JustWalters
commented
Apr 22, 2025
| @@ -74,6 +74,7 @@ export default class EnvoyAPI { | |||
|
|
|||
| (included || []) | |||
| .concat(modelOrModels) | |||
| .filter((model: JSONAPIData | null) => model !== null) | |||
There was a problem hiding this comment.
Fix the return type of storage method(s).
There was a problem hiding this comment.
This also affects delete (at least for sign-in-fields).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to storage where the field doesn't exist return an array with a single null element. That throws an error when trying to access .type
Most (this is an assumption, but the several I've tested) routes return a 404 when there's no data so we never get to data loader.
Other v3 changes can include: