MODLD-733: Marc 490 - Create ISSN node only when $x is present

[pkjacob]

This is the exact same PR that was approved earlier - #99

I just realized that the previous PR was created against a wrong branch. :(

[Copilot]

Pull Request Overview

This PR ensures that an ISSN node is only created for MARC 490 when subfield $x is present.

• Added a new test fixture without subfield $x to validate no ISSN mapping.
• Extended the Marc2Ld490IT integration test to cover the "no ISSN" scenario.
• Updated marc4ld.yml to include a marc2ldCondition that requires subfield x.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/test/resources/fields/490/marc_490_no_issn.jsonl	New test resource for a 490 record missing subfield x
src/test/java/org/folio/marc4ld/mapper/field490/Marc2Ld490IT.java	Added shouldMapField490WithoutIssn test and helper
src/main/resources/marc4ld.yml	Added marc2ldCondition.fieldsAllOf for subfield x

Comments suppressed due to low confidence (1)

src/test/java/org/folio/marc4ld/mapper/field490/Marc2Ld490IT.java:73

• [nitpick] Consider renaming hasNoIssnIdentifier to assertNoIssnIdentifierEdges to better convey its assertion behavior.

private void hasNoIssnIdentifier(Resource instanceSeries) {

[Copilot]

Pull Request Overview

This PR ensures that an ISSN node is only created for MARC field 490 when subfield $x is present by adding a new conditional in the mapping rules and covering the missing‐ISSN case in tests.

• Introduce a JSON test fixture without $x to verify no ISSN mapping.
• Add an integration test validating absence of ISSN edges.
• Update marc4ld.yml to apply the ISSN mapping only if subfield x is present.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/test/resources/fields/490/marc_490_no_issn.jsonl	New test input without an ISSN subfield
src/test/java/org/folio/marc4ld/mapper/field490/Marc2Ld490IT.java	Integration test for the "no ISSN" scenario
src/main/resources/marc4ld.yml	Added marc2ldCondition to require subfield x

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud