MODLD-733: Marc 490 - Create ISSN node only when $x is present

src/main/resources/marc4ld.yml

@@ -645,6 +645,9 @@ bibFieldRules:
                     x: NAME
                   ld2marcCondition:
                     skip: true
+                  marc2ldCondition:
+                    fieldsAllOf:
+                      x: presented
 
   500:
     - types: INSTANCE

src/test/java/org/folio/marc4ld/mapper/field490/Marc2Ld490IT.java

@@ -14,11 +14,13 @@
 import static org.folio.marc4ld.mapper.test.TestUtil.validateEdgeWithSource;
 import static org.folio.marc4ld.test.helper.ResourceEdgeHelper.getFirstIncomingEdge;
 import static org.folio.marc4ld.test.helper.ResourceEdgeHelper.getFirstOutgoingEdge;
+import static org.folio.marc4ld.test.helper.ResourceEdgeHelper.getOutgoingEdges;
 import static org.folio.marc4ld.test.helper.ResourceEdgeHelper.getWorkEdge;
 import static org.folio.marc4ld.test.helper.ResourceEdgeHelper.withPredicateUri;
 
 import java.util.List;
 import java.util.Map;
+import org.folio.ld.dictionary.model.Resource;
 import org.folio.ld.dictionary.model.ResourceEdge;
 import org.folio.marc4ld.Marc2LdTestBase;
 import org.junit.jupiter.api.Test;
@@ -47,6 +49,32 @@ void shouldMapField490() {
       .satisfies(this::validateIssnIdentifier);
   }
 
+  @Test
+  void shouldMapField490WithoutIssn() {
+    // given
+    var marc = loadResourceAsString("fields/490/marc_490_no_issn.jsonl");
+
+    // when
+    var result = marcBibToResource(marc);
+
+    // then
+    assertThat(getWorkEdge(result).getTarget())
+      .extracting(work -> getFirstOutgoingEdge(work, withPredicateUri("http://bibfra.me/vocab/relation/isPartOf")))
+      .satisfies(this::validateWorkSeries)
+      .extracting(workSeries ->
+        getFirstOutgoingEdge(workSeries, withPredicateUri("http://bibfra.me/vocab/relation/isPartOf")))
+      .satisfies(this::validateSeries)
+      .extracting(series -> getFirstIncomingEdge(series, withPredicateUri("http://bibfra.me/vocab/lite/instantiates")))
+      .satisfies(this::validateInstanceSeries)
+      .extracting(ResourceEdge::getSource)
+      .satisfies(this::hasNoIssnIdentifier);
+  }
+
+  private void hasNoIssnIdentifier(Resource instanceSeries) {
+    var issnEdges = getOutgoingEdges(instanceSeries, withPredicateUri("http://library.link/vocab/map"));
+    assertThat(issnEdges).isEmpty();
+  }
+
   private void validateWorkSeries(ResourceEdge workSeries) {
     validateEdge(workSeries, IS_PART_OF, List.of(WORK, SERIES),
       Map.of(

src/test/resources/fields/490/marc_490_no_issn.jsonl

@@ -0,0 +1,22 @@
+{
+  "leader": "00124nam a2200061uc 4500",
+  "fields": [
+    {
+      "008": "                                       "
+    },
+    {
+      "490": {
+        "subfields": [
+          {
+            "a": "name"
+          },
+          {
+            "v": "volume"
+          }
+        ],
+        "ind1": " ",
+        "ind2": " "
+      }
+    }
+  ]
+}