fix(browser): Ensure spans auto-ended for navigations have cancelled reason
#16277
+94
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
approved these changes
May 13, 2025
s1gr1d
approved these changes
May 13, 2025
| @@ -30,6 +30,7 @@ sentryTest('creates a pageload transaction with url as source', async ({ getLoca | |||
| [SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 1, | |||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url', | |||
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'pageload', | |||
| ['sentry.idle_span_finish_reason']: 'idleTimeout', | |||
There was a problem hiding this comment.
L: Would it make sense to create a variable for this string as well?
There was a problem hiding this comment.
we have, but not publicly exported (not meant to be used by users) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that this now has
externalFinishas reason, which is not really helpful. With this, you should be able to see that the pageload/navigation was ended because a new one started.