fix: Make fetching scene name run on IL2CPP only #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
commented
Jun 23, 2025
| @@ -135,7 +135,7 @@ internal SentryUnityOptions ToSentryUnityOptions(bool isBuilding, ISentryUnityIn | |||
| { | |||
| application ??= ApplicationAdapter.Instance; | |||
|
|
|||
| var options = new SentryUnityOptions(isBuilding, application) | |||
| var options = new SentryUnityOptions(isBuilding, application, unityInfo) | |||
There was a problem hiding this comment.
We need to pass the UnityInfo into the options if we want to have access to IL2CPP from within the integrations.
Alternatively, I'd need to add the integrations here but this would be a breaking change in behaviour for anyone that programmatically initializes the SDK.
I'll have to pick this back up when working on #2200
bitsandfoxes
commented
Jun 24, 2025
Flash0ver
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2181