Skip to content

Core: Unify display of error type prefixes #100899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Dec 29, 2024

Before:

$ godot4 --headless -d -s script.gd
Godot Engine v4.3.stable.official.77dcf97d8 - https://godotengine.org

ERROR: 'The local variable "a" is declared but never used in the block. If this is intended, prefix it with an underscore: "_a".'
ERROR: 'Using assignment with operation but the variable "a" was not previously assigned a value.'

After:

$ ./godot.linuxbsd.editor.dev.x86_64 --headless -d -s script.gd
Godot Engine v4.4.dev.custom_build.56bfe4558 (2024-12-29 11:49:01 UTC) - https://godotengine.org

WARNING: The local variable "a" is declared but never used in the block. If this is intended, prefix it with an underscore: "_a".
     at: GDScript::reload (res://script.gd:4)
WARNING: Using assignment with operation but the variable "a" was not previously assigned a value.
     at: GDScript::reload (res://script.gd:5)

@dalexeev dalexeev added this to the 4.4 milestone Dec 29, 2024
@dalexeev dalexeev requested review from a team as code owners December 29, 2024 11:43
@dalexeev dalexeev force-pushed the core-unify-display-of-error-type-prefixes branch from 9db0ce8 to 56bfe45 Compare December 29, 2024 11:49
@dalexeev dalexeev force-pushed the core-unify-display-of-error-type-prefixes branch from 56bfe45 to 7e22a90 Compare December 29, 2024 12:04
@dalexeev dalexeev force-pushed the core-unify-display-of-error-type-prefixes branch from 7e22a90 to 0208aa9 Compare January 3, 2025 16:27
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
@dalexeev dalexeev force-pushed the core-unify-display-of-error-type-prefixes branch from 0208aa9 to cd13a6a Compare May 5, 2025 16:57
@Repiteo
Copy link
Contributor

Repiteo commented Jun 9, 2025

Needs rebase

@dalexeev dalexeev force-pushed the core-unify-display-of-error-type-prefixes branch from cd13a6a to 24494d8 Compare June 9, 2025 17:20
@dalexeev
Copy link
Member Author

dalexeev commented Jun 9, 2025

Needs rebase

Done.

@Repiteo Repiteo merged commit 8ecc6da into godotengine:master Jun 9, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 9, 2025

Thanks!

@dalexeev dalexeev deleted the core-unify-display-of-error-type-prefixes branch June 10, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants