Fix crash when using a modulo operator between a float and an integer

[xsellier]

Thanks to this change this scripts:

extends SceneTree

func _init():
  var result = randi() % floor(10.0)

Returns this error:

SCRIPT ERROR: Invalid operands 'int' and 'float' in operator '%'.
          at: _init (res://crash.gd:4)

Otherwise it used to crash

Bugsquad edit:

• Fixes Calling randi() % floor(2.0) causes engine to crash silently #80486

[akien-mga]

Could you amend the commit title and PR title to be an explicit description of what bug is being fixed, and not what issue number or how it's fixed? See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind for our guidelines on commit messages.

[xsellier]

Could you amend the commit title and PR title to be an explicit description of what bug is being fixed, and not what issue number or how it's fixed? See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind for our guidelines on commit messages.

Done, sorry for that commit message, I should have known better

[xsellier]

Any news on that matter ?

[vnen]

I'm a bit torn about this. On one hand it does solve the crash in a simple way, but it also postpones the error until runtime (and the error will happen). We can catch the error on editor and show it to the user, which is why I prefer my own take in #83559 (which is more intrusive, sure, but it's also better usability).

We could merge this to solve the crash. But then I wonder if we ever gonna improve the editor for this case.

I guess it's better to stop the crash for now.

[Repiteo]

Thanks!