Increase size of Offset field in audio import dialog #103029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
reviewed
Feb 19, 2025
|
|
Calinou
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Looks good to me.
We could perhaps switch to a minutes:seconds display in the future, but we'd also need to support entering minutes:seconds values. This would likely involve parsing them with a LineEdit instead of using SpinBox, which means we'd lose on dragging support though.
|
Simple QOL fix. I think it's good. Fire has consensus for everything and defers the decision about units, and Calinou agrees about units, so I think there's enough consensus to get this merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the field annoyingly small and hide information, so I made it bigger.
Before:
After:
(same value)
I also changed the suffix to s.
Somewhat related to #64538