Fix EditorObjectSelector popup size #103125
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's Button probably for its style. |
Think I understand why it's a button now. |
KoBeWi
approved these changes
Feb 21, 2025
akien-mga
force-pushed
the
editor-object-selector-popup
branch
from
5af969c to
d8376e6
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #101876 made the popup size for OptionButtons be as wide as the button itself.
This did not apply to EditorObjectSelectors PopupMenu. Becuase it's just a button that looks like an OptionButton.
This PR makes the Popup behave like it does for mentioned PR above.
Before:
Screencast_20250219_053311.webm
After:
Screencast_20250219_053329.webm
Another solution could probably be to change EditorObjectSelector to an OptionButton, but not sure why it's currently a Button and what affects that would have.