-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
ColorChannelSelector
: add tooltip, fix toggle_button
repositioning and channels autotranslation
#104474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
93988bf
to
f980c2c
Compare
I suppose this one still may fit 4.5 because it fixes several bugs in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about removing the constant. If it was not used consistently, then you can make it consistent.
Other changes are fine.
Got it, thanks. I'll revert all code style changes I made in PR (even if code style is inconsistent, it doesn't affect functionality). |
…g and channels autotranslation
f980c2c
to
6e2193b
Compare
Pushed commit without codestyle changes. The only "codestyle" changes are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't speak to the code but approving on style
Thanks! |
Changes:
toggle_button
changing its position, caused by the panel size.toggle_button
to clarify its purpose.toggle_button
theming to use "PreviewLightButton" type variation, aligning it with similar buttons (like inMaterialEditor
).EditorScale::get_scale()
replaced with more commonEDSCALE
,removeduseCHANNEL_COUNT
(it was inconsistentty used anyway), removed debug error checks fromcreate_button()
(redundant, the function is only called in constructor and with known arguments)CHANNEL_COUNT
everywhere (seeColorChannelSelector
: add tooltip, fixtoggle_button
repositioning and channels autotranslation #104474 (comment)).4.5dev1:
NVIDIA_Share_WlYS839r7b.mp4
This PR:
godot.windows.editor.dev.x86_64_cghwXM6u7K.mp4