Skip to content

ColorChannelSelector: add tooltip, fix toggle_button repositioning and channels autotranslation #104474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

arkology
Copy link
Contributor

@arkology arkology commented Mar 22, 2025

Changes:

  • Fixed issue with toggle_button changing its position, caused by the panel size.
  • Added tooltip for toggle_button to clarify its purpose.
  • Prevented accidental translation of color channel names in certain languages (e.g., Arabic).
  • Updated toggle_button theming to use "PreviewLightButton" type variation, aligning it with similar buttons (like in MaterialEditor).
  • Code cleanup: EditorScale::get_scale() replaced with more common EDSCALE, removed CHANNEL_COUNT (it was inconsistentty used anyway), removed debug error checks from create_button() (redundant, the function is only called in constructor and with known arguments) use CHANNEL_COUNT everywhere (see ColorChannelSelector: add tooltip, fix toggle_button repositioning and channels autotranslation #104474 (comment)).

4.5dev1:

NVIDIA_Share_WlYS839r7b.mp4

This PR:

godot.windows.editor.dev.x86_64_cghwXM6u7K.mp4

@Chaosus Chaosus added this to the 4.x milestone Mar 23, 2025
@Chaosus Chaosus added the bug label Mar 23, 2025
@arkology arkology force-pushed the color-channel-selector branch from 93988bf to f980c2c Compare May 24, 2025 16:15
@arkology
Copy link
Contributor Author

I suppose this one still may fit 4.5 because it fixes several bugs in ColorChannelSelector. If some changes are unnecessary (code cleanup, theme tweaks) I can just drop them.
@KoBeWi could you please take a look? Thanks.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about removing the constant. If it was not used consistently, then you can make it consistent.

Other changes are fine.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.5 Jun 17, 2025
@arkology
Copy link
Contributor Author

Got it, thanks. I'll revert all code style changes I made in PR (even if code style is inconsistent, it doesn't affect functionality).

@arkology arkology force-pushed the color-channel-selector branch from f980c2c to 6e2193b Compare June 17, 2025 12:39
@arkology
Copy link
Contributor Author

Pushed commit without codestyle changes. The only "codestyle" changes are:

@arkology arkology requested a review from AThousandShips June 17, 2025 12:44
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the code but approving on style

@Repiteo Repiteo merged commit 50a363b into godotengine:master Jun 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 18, 2025

Thanks!

@arkology arkology deleted the color-channel-selector branch June 19, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants