-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Fix differences between RayCast2D and RayCast3D documentation #105048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix differences between RayCast2D and RayCast3D documentation #105048
Conversation
c75ae67
to
0d0d24b
Compare
0d0d24b
to
01983d0
Compare
01983d0
to
b7c0aa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine now from a physics perspective. Thanks!
I seem to recall a general comment saying that using parameter names as substitutes for words is not the most translation-friendly approach, but I'll leave that for someone else to decide.
That may be from me, actually, as well as from others. As personal notes, I wrote as follows:
Parameters replacing words something done very commonly across the class reference, and it's a bit debatable. There's no real guideline, too. In my opinion, linking the parameter directly here brings attention to its type without repetition and makes the subject clearer. But there's a lot of occasions where it does, in fact, suck. |
b7c0aa5
to
621500c
Compare
Thanks! |
Similar to #104354
This PR addresses differences between the documentation of RayCast2D and RayCast3D (within reason). It also fixes an inconsistency that popped up as a result of #101373
This comes with the goal not only making the two consistent, but also reducing the overall amount of strings to localize.