Skip to content

GDScript: Add autocompletion for @export_tool_button #105081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Apr 6, 2025

@dalexeev dalexeev added this to the 4.5 milestone Apr 6, 2025
@dalexeev dalexeev requested a review from a team as a code owner April 6, 2025 05:22
@HolonProduction
Copy link
Member

HolonProduction commented Apr 6, 2025

I'd usually say we should quote all argument option preview strings for consistency, but in this case it makes sense to not do that, since the editor won't show the icons for quoted names.

With this PR the autocompletion depends on EditorNode, thus the completion test case should be marked as editor test case. Also a basic test case for this would be nice (if the theme is available in tests that is).

@Mickeon Mickeon added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Apr 6, 2025
@Mickeon
Copy link
Member

Mickeon commented Apr 6, 2025

In my opinion this should've been done sooner than later. The icon parameter may as well not exist because most users don't realise what is available to them or (reasonably) assume it works like @icon.

@Repiteo Repiteo merged commit 3b963ab into godotengine:master Jun 9, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 9, 2025

Thanks!

@dalexeev dalexeev deleted the gds-add-export-tool-button-autocompletion branch June 9, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release enhancement topic:editor topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants