Ignore rename shortcut when Remote tab is active #106688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.3
|
IMO blocking every shortcut is too much. Right now you can e.g. select nodes in 2D editor and delete them, and it will be synced with the running project. Selecting a node will deselect any selected remote node, and show the selected node in the inspector, so I think this behavior is fine. The main problem here is that renaming a node with visible remote tree is broken. The popup appears at wrong position and the rename takes no effect. |
sakubou
force-pushed
the
106306-ignore-f2-in-remote-tab
branch
from
56ffb78 to
6896a76
Compare
|
Okay understood! I’ve adjusted it to solely block the rename shortcut. |
KoBeWi
reviewed
Jun 3, 2025
| @@ -184,6 +184,9 @@ void SceneTreeDock::shortcut_input(const Ref<InputEvent> &p_event) { | |||
| if (focus_owner && (Object::cast_to<BaseButton>(focus_owner) || Object::cast_to<Range>(focus_owner))) { | |||
| return; | |||
| } | |||
| if (edit_remote->is_pressed()) { | |||
KoBeWi
approved these changes
Jun 3, 2025
|
Thanks! |
KoBeWi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106306
In shortcut_input(), an early exit is now taken if edit_remote->is_pressed(), skipping all local-node shortcuts (e.g. rename, delete, cut).