Skip to content

[Web] Fix build failure on Windows #107112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

AThousandShips
Copy link
Member

Follow up to:

In PowerShell (at least, haven't tried with other shells) the pipe characters are not interpreted as part of the expression, leading to:

[ 67%] em++: error: error parsing "-s" setting "PTHREAD_POOL_SIZE='Module[emscriptenPoolSize]": unclosed quoted string. expected final character to be "'" and length to be greater than 1 in "'"
[ 68%] '8'' is not recognized as an internal or external command, operable program or batch file.

Swapping the quote characters solves this issue (though I don't know how to confirm that the result is parsed correctly in either case)

@AThousandShips AThousandShips added this to the 4.5 milestone Jun 4, 2025
@AThousandShips AThousandShips requested a review from a team as a code owner June 4, 2025 11:00
@AThousandShips AThousandShips requested a review from a team June 4, 2025 11:01
@akien-mga akien-mga changed the title [Web,Windows] Fix build failure on Windows [Web, Windows] Fix build failure on Windows Jun 4, 2025
@AThousandShips AThousandShips moved this from Unassessed to Release Blocker in 4.x Release Blockers Jun 16, 2025
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test easily, but given that CI passed it seems to not impact the build from Linux.

Could you confirm this works on Windows in both PowerShell and cmd.exe?

@akien-mga akien-mga changed the title [Web, Windows] Fix build failure on Windows [Web] Fix build failure on Windows Jun 16, 2025
@AThousandShips

This comment was marked as resolved.

@AThousandShips
Copy link
Member Author

Can confirm that:

  • The original bug also occurs in cmd
  • This fixes the same bug with cmd and it builds correctly

@Repiteo Repiteo merged commit 7b4f98c into godotengine:master Jun 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 18, 2025

Thanks!

@AThousandShips AThousandShips deleted the fix_web_build branch June 19, 2025 07:31
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

Successfully merging this pull request may close these issues.

3 participants