Android: Fix save issue when using native file dialog #107207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue where saving a file without `MANAGE_EXTERNAL_STORAGE` permission using the `native file dialog` to get the file path causes the `ERR_FILE_NOT_FOUND` error.
syntaxerror247
added
the
cherrypick:4.4
m4gr3d
reviewed
Jun 6, 2025
m4gr3d
approved these changes
Jun 10, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where saving a file without
MANAGE_EXTERNAL_STORAGEpermission using thenative file dialogto get the file path causes theERR_FILE_NOT_FOUNDerror.A blank file gets created by default when using the save dialog, which isn't available to the Godot app without required permission (MANAGE_EXTERNAL_STORAGE) and when trying to access that file using
FileAccess(mediastore api) with the path returned byFileDialog, results inERR_FILE_NOT_FOUNDerror (as shown in the linked issue description).There's no way to stop this blank file creation, so this PR immediately deletes the blank file instead.
This change also brings Android's behavior in line with desktop platforms, where no blank file is created when saving using the native file dialog.
Fixes #107206