OpenGL: Fix shader compilation failure with shadow_to_opacity
and unshaded
#107238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if you make a shader that uses both
shadow_to_opacity
andunshaded
when using the Compatibility renderer, it will fail to compile with the following error:This PR fixes that!
This problem doesn't happen with the Forward+ or Mobile renderers, where the result is full transparency (
alpha = 0.0
), even though the scene shaders in those renders don't set it explicitly, like in this PR. I don't know if it'd be worth changing Forward+ and Mobile to do it explicitly too?