Skip to content

Spinbox: Fix incorrect step and decimal text when using custom arrow step #107302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

beicause
Copy link
Contributor

@beicause beicause commented Jun 9, 2025

Fixes #107271 and makes the value correctly snapped to next step.

_20250609_131829.webm

@beicause beicause requested a review from a team as a code owner June 9, 2025 05:23
@AThousandShips AThousandShips added bug topic:gui cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Jun 9, 2025
@AThousandShips AThousandShips added this to the 4.5 milestone Jun 9, 2025
@beicause
Copy link
Contributor Author

beicause commented Jun 9, 2025

This doesn't work properly with decimal step yet. And will lead to issue #97561, not sure how to avoid that.
Edit: Resolved.

2025/7/5 Edit: This PR doesn't resolve #97561, my previous comment was wrong.

@beicause beicause marked this pull request as draft June 9, 2025 09:16
@beicause beicause force-pushed the spinbox-fix-decimal-step-using-arrow branch from 4ff996c to 81406ff Compare June 9, 2025 11:00
@beicause beicause marked this pull request as ready for review June 9, 2025 11:03
@Repiteo Repiteo merged commit 141508a into godotengine:master Jun 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 18, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release regression topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinbox incorrect decimal text when it gets focused with custom arrow step and updates externally
5 participants